Document the yaml_file usage #11121
Closed
Document the yaml_file usage #11121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeahDude
reviewed
Mar 10, 2019
OskarStark
reviewed
Mar 10, 2019
OskarStark
requested changes
Mar 10, 2019
service_container.rst
Outdated
| <container xmlns="http://symfony.com/schema/dic/services" | ||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:schemaLocation="http://symfony.com/schema/dic/services | ||
| http://symfony.com/schema/dic/services/services-1.0.xsd"> |
There was a problem hiding this comment.
None of the previous examples use https, sure about that one?
There was a problem hiding this comment.
#11122 is on the go, any addition should be secure now.
carsonbot
added
Status: Needs Work
Status: Needs Review
and removed
Status: Needs Work
labels
OskarStark
approved these changes
Mar 11, 2019
|
Can we merge this? |
|
We can't merge!! The related code PR hasn't been merged, right? symfony/symfony#30446 |
|
Sorry I wanted to comment in the code PR 😊 |
|
The code PR was not merged, so let’s close this one. Anyway thank you for working on this 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: symfony/symfony#30446